This Smelly Code post discusses mainly a testability issue without going into further detail on other things like readability which could be improved for sure as well. Original, smelly code public Account ReadCompleteAccountByADUsernameAndServiceUID(string adUsername, string serviceInstanceUID) { IList<Address>> addresses; IList<Contact> contacts; MasterDataBL masterDataBL = new MasterDataBL(); Account result = AccoDao.ReadCompleteAccountByADUsernameAndServiceUID(adUsername, serviceInstanceUID, ConnectionString.Master, out addresses, out […]
↧